Skip to content

Add support for single end data and switch to python3#71

Open
nictru wants to merge 11 commits into
bioinfo-biols:masterfrom
nictru:master
Open

Add support for single end data and switch to python3#71
nictru wants to merge 11 commits into
bioinfo-biols:masterfrom
nictru:master

Conversation

@nictru

@nictru nictru commented Aug 24, 2024

Copy link
Copy Markdown

Hello everyone,

First of all, thanks for the fantastic package. This PR contains the changes mentioned in the title. Both did not require a lot of code changes.

Updating to python3 allows using current versions of various dependencies. It also helps overcome some problems with bundling for bioconda (related PR).

Adding support for single-stranded datasets allows wider usage of the package. I understand that this needs to be thoroughly evaluated before it can make it into production.

If you are interested in adding these changes to the package, I am eager to contribute. If not, I will most likely keep maintaining a fork, as these functionalities are important for my use case.

@Kevinzjy

Copy link
Copy Markdown
Member

Hi @nictru , thanks a lot for the helpful PR. There may be some concerns about the code for identifying single-ended / paired-ended BSJ reads. I will look into this, but maybe not very soon. Once done, I will be very happy to merge these codes into the next release.

@nictru

nictru commented Aug 25, 2024

Copy link
Copy Markdown
Author

Maybe I can perform an evaluation similar to the one in the paper on single-stranded data to increase confidence

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants