Bound Wi-Fi scan results to fixed storage - #1853
Open
Distortions81 wants to merge 1 commit into
Open
Conversation
Test Results 2 files 2 suites 1s ⏱️ Results for commit e541ddf. |
Distortions81
marked this pull request as ready for review
August 7, 2026 22:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wifi_scan()and clamp both copy boundaries.Root cause and impact
The driver-reported AP total was reused as capacity for a fixed 20-entry global array, then reused for a fixed 20-entry HTTP stack array. A dense scan could write beyond both buffers. The endpoint still returns at most 20 networks; excess results are safely ignored.
This preserves the trusted-network design and adds no authentication or access control.
Related work
Validation
git diff --check upstream/master...HEADA hardware scan with more than 20 visible APs remains desirable.