-
Notifications
You must be signed in to change notification settings - Fork 508
contrib: add a Dockerfile to run the website locally #1184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
(This is based on the CI config) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 9f7a431
PR adds dockerfile (based on ci) and edited readme in contrib with instruction so that the bitcoincore.org website can be run locally for easy testing of changes.
This is a valuable addition and makes testing the changes locally easier without installing all the dependencies on the base machine.
- code reviewed ✅
- followed instructions to run it locally ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 9f7a431
Dockerfile is nice and tidy, and works well in testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Concept ACK, but I think incrementally building the site at runtime makes more sense than doing it at build time (see suggestion).
Although I like the suggestions, I think this PR container is ment to behave like the "real website" and therefor is an (almost) duplicate of the CI . |
Co-Authored-By: stickies-v <[email protected]>
9f7a431
to
3a3b610
Compare
Thanks @stickies-v for the |
It was useful to me, so i cleaned it up and PR'd it in case others do not have a full Ruby toolchain installed, but do have Docker.