-
Notifications
You must be signed in to change notification settings - Fork 49
Add Multiple Recipients option to the Send form #450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- the amount is not tied to each recipient. If I enter x at 1, all have amount x
- small nit, could this be centered
I believe I have both of these issues resolved now with the latest commits. |
Discovered an issue with the calculation of the total amount in the review ui and coin selection ui. Will resolve that today. |
This should be resolved now with the last two commits. |
Looks great.
Not sure if that outline is easy to follow, but by guess is that the current recipient is correctly being removed, but the UI is not being refreshed.
|
I think this is the issue. I think I know what signal is missing and I will try it out.
There is currently no limit. I'll put it at 25 just so we have something
I think per recipient/output might make more sense but i can see the value of per transaction. Note to self isn't implemented yet so that part of the form just goes no where. I still need to figure out what is supported currently in core for this as that might dictate which way we go. |
The SendRecipientsListModel is owned by WalletQmlModel
This merges BitcoinAmount with SendRecipient to simplify the qml logic. By doing so, the conversions can be managed all in c++ against the satoshi member variable. Each recipient having its own BitcoinAmount allows the amounts to be saved independantly when there are multiple recipients.
These two issues are now resolved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8a6b593
I found multiple things, probably some are to be fixed and some can be follow-up.
- Have 2 recipients, delete recipient 2. It stays at recipient 2 and displays
Recipient 2 of 1
:
- I noticed a delay in the coin selection
Remaining to select
/Over required amount
, this does not happen on master
Screencast.from.2025-06-04.09-12-47.webm
- Have multiple recipients, one in sats and the other in BTC -> the Transaction Details screen is confusing as it doesn't have units:
Some issues when having 2 or more recipients and disabling Multiple Recipients
as the other disabled recipients are still taken into account:
- After disabling multiple recipients, the Send view will show the current selected single recipient, but the amount in
Transaction Details
is the sum of the multiple recipients (even though disabled)
Screencast.from.2025-06-04.09-07-22.webm
- Recipient 2 is empty, disable
Multiple Recipients
. Send view is at recipient 1 (with address and amount) butReview
doesn't work.
I also noticed a few additional things to the ones mentioned above:
![]()
|
Found the off by one error. It should work correctly now.
This is a similar fix to the validation. I've push the fix to this PR as well.
The transaction details I will create a new task/issue as a follow up as I would like to do a bunch of amount labels at once.
I now have it clearing out the list up to the first recipient when the setting is disabled and the amounts should be correct now. |
All comments have been addressed via a commit or new issue. |
Awesome progress. Not sure if it's covered elsewhere, here are some things I am seeing based on the latest code:
|
These two are addressed in #462
This makes sense, will add
I'll make an issue to track this for a follow up. I need to refactor some things to get the setting to be global.
Will fix.
Ill try to fix this as well. |
This change introduces the multiple recipients controls to the Send form. It is enabled in the ellipses option menu by toggling on "Enable Multiple Recipients". This is stored as a QSetting for the user.
This PR depends on #448 which contains the
first implementation of the Send options menu.