snap: Incorporate desktop-launch source code
#306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rebased on top of the merged #298. |
|
ACK f3907d4 |
|
I tested this when you created the pull, IIRC. However, I could not find a difference and why this was needed. Maybe I am missing something. Can you share a screenshot or steps to reproduce the issue that this is fixing? |
This paved the way to #312. Otherwise, it won't build due to Qt5-specifc code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snapcraft has moved from desktop helpers to desktop extensions, which appears to have limited portability.
This PR incorporates the minimum required code from https://github.com/ubuntu/snapcraft-desktop-helpers to help maintain package portability and support the migration to Qt 6, as used in Bitcoin Core v30.0.