-
Notifications
You must be signed in to change notification settings - Fork 75
Adding descriptor generator #180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AmosOO7
wants to merge
7
commits into
bitcoindevkit:master
Choose a base branch
from
AmosOO7:adding_descriptor_generator
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvpeter
reviewed
May 6, 2025
09b4f4a
to
ebf6be3
Compare
tvpeter
suggested changes
May 12, 2025
tvpeter
suggested changes
May 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work Amos.
Most of the fns in utils
should be in the handlers
file, while most of those in handlers
should be placed in the utils
.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new
descriptor
subcommand to the BDK CLI that enables users to generate Bitcoin wallet descriptors for internal and external paths, supporting common BIP standards (44, 49, 84, 86). It includes support for both single-path and multipath descriptors using an extended key (tprv/tpub).This resolves issue #175
Features Implemented
descriptor
subcommand--multipath
for wildcard derivation paths--type
defaults to84
--network
defaulttestnet
--multipath
defaults tofalse
Usage Examples
1. Generate a Private Key (Seed Phrase)
2. Generate Descriptors from a Provided Private Key
Generate a Descriptor from a Seed Phrase (no key provided)
Generate Multipath Descriptor from Xpub key
cargo fmt
andcargo clippy
before committingNew Features:
CHANGELOG.md