Add DerivationPath helper methods

[ItoroD]

Description

Notes to the reviewers

Added more useful methods for DerivationPath for now I added the simplest ones. More should be added later; like child, into_child.

Checklists

All Submissions:

• I've signed all my commits
• I followed the contribution guidelines
• I ran cargo fmt and cargo clippy before committing
• I've added a changelog in the next release tracking issue (see example)

New Features:

• I've added tests for the new feature
• I've added docs for the new feature

[reez]

I dig this addition. Are you going to add #[uniffi::export(Display)] to DerivationPath?

[ItoroD]

I dig this addition. Are you going to add #[uniffi::export(Display)] to DerivationPath?

Good call.

[thunderbiscuit]

This is looking good! I would need 2 things before merging:

1. Rebase on latest (new commit comming from Refactor DerivationPath to use tuple #895)
2. Add a commit that refactors the KeySource type to use DerivationPath instead of String.

[ItoroD]

This is looking good! I would need 2 things before merging:

1. Rebase on latest (new commit comming from Refactor DerivationPath to use tuple #895)
2. Add a commit that refactors the KeySource type to use DerivationPath instead of String.

Done! Just arranged the commits in second push

[thunderbiscuit]

Just a few cleanup ideas.

[thunderbiscuit]

The spaces here I thought would have been caught by the cargo formatter, but they weren't. Those lines could be cleaned up as:

fingerprint: v.1.0.to_string(),
path: Arc::new(v.1.1.clone().into()),

[thunderbiscuit]

Man those deeply nested types are quite a handful 😆😆😆

[ItoroD]

Cargo fmt is actually the one adding those spaces

[thunderbiscuit]

I don't think they hurt much, but in general I'm wary of adding trait implementations that are not needed. Note also that those are not exported to the bindings, so they'd need to be useful at the Rust layer, but I don't know that they are for now (the Clone is, but not the Eq, PartialEq, and Hash).

[thunderbiscuit]

After playing with it locally, the Debug trait is also used (as well as the Clone). Others can be dropped on this one and others that have them.

[ItoroD]

good call

[thunderbiscuit]

I think you're missing the Display trait export here:

#[derive(Debug)]
#[derive(uniffi::Object)]
#[uniffi::export(Display)]
pub struct DerivationPath(pub(crate) BdkDerivationPath);

[thunderbiscuit]

You have the Display implemented below, but bindings users won't get it unless we add the #[uniffi::export(Display)] line.

[ItoroD]

Again! I thought I added that. I really do need to "Shine my eye". Maybe lost on rebase and merge resolution. Thanks

[thunderbiscuit]

ACK ffcae65.