Skip to content

chore: split bdk_wallet into it's own repository #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 4, 2025

Conversation

notmandatory
Copy link
Member

Description

Remove everything from the original bdk repo not related to bdk_wallet. Other crates remain in the original bdk repository.

Update README and Cargo files.

Notes to the reviewers

After this is merged I'll move all bdk_wallet related issues from the bdk repo to this repository. Any PRs in the bdk repo will need to be manually moved by their owners.

Changelog notice

  • Remove everything from the bdk repo not related to bdk_wallet. Other crates remain in the original bdk repository.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@notmandatory notmandatory self-assigned this Apr 3, 2025
@notmandatory notmandatory added the chore Non-coding related work label Apr 3, 2025
@notmandatory notmandatory moved this to Needs Review in BDK Wallet Apr 3, 2025
@notmandatory notmandatory force-pushed the chore/only_bdk_wallet branch from f12faa9 to af6633e Compare April 3, 2025 20:38
Update README and Cargo files.

Remove everything not related to bdk_wallet. Other crates
remain in the original bdk repository.
@notmandatory notmandatory force-pushed the chore/only_bdk_wallet branch from af6633e to 2a79bab Compare April 3, 2025 20:40
@luisschwab
Copy link
Member

Maybe remove the crates folder, since there will only be the wallet crate?

@notmandatory
Copy link
Member Author

I flattened/removed the crates directory and renamed example-crates to just examples since that old name always bugged me.

@notmandatory notmandatory force-pushed the chore/only_bdk_wallet branch 2 times, most recently from eca5358 to 3fb6402 Compare April 3, 2025 23:47
@notmandatory
Copy link
Member Author

This is ready to go.

@notmandatory notmandatory force-pushed the chore/only_bdk_wallet branch from 3fb6402 to 175f5d4 Compare April 4, 2025 01:05
Copy link
Member

@luisschwab luisschwab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 175f5d4

Copy link
Collaborator

@ValuedMammal ValuedMammal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 175f5d4

@ValuedMammal ValuedMammal merged commit 3e61d2a into master Apr 4, 2025
30 checks passed
@github-project-automation github-project-automation bot moved this from Needs Review to Done in BDK Wallet Apr 4, 2025
@notmandatory notmandatory deleted the chore/only_bdk_wallet branch April 4, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Non-coding related work
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants