Skip to content

chore(example_wallet_rpc): bump ctrlc to 3.4.6 #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2025
Merged

chore(example_wallet_rpc): bump ctrlc to 3.4.6 #217

merged 1 commit into from
Apr 30, 2025

Conversation

luisschwab
Copy link
Member

Description

This PR bumps ctrlc to 3.4.6 (latest) on example_wallet_rpc and also fixes a clippy warning.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@luisschwab luisschwab mentioned this pull request Apr 24, 2025
Open
6 tasks
@coveralls
Copy link

Pull Request Test Coverage Report for Build 14651830294

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.525%
Totals Coverage Status
Change from base Build 14270666930: 0.0%
Covered Lines: 7269
Relevant Lines: 8401
💛 - Coveralls

@notmandatory notmandatory moved this to Needs Review in BDK Wallet Apr 26, 2025
notmandatory
notmandatory approved these changes Apr 26, 2025
View reviewed changes
Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 89f0f3b

@notmandatory notmandatory added this to the Wallet 2.0.0 milestone Apr 26, 2025
@notmandatory notmandatory added the dependencies Pull requests that update a dependency file label Apr 26, 2025
ValuedMammal
ValuedMammal approved these changes Apr 30, 2025
View reviewed changes
Copy link
Collaborator

@ValuedMammal ValuedMammal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 89f0f3b

@ValuedMammal ValuedMammal merged commit 6d2f3b9 into bitcoindevkit:master Apr 30, 2025
14 checks passed
@github-project-automation github-project-automation bot moved this from Needs Review to Done in BDK Wallet Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notmandatory notmandatory notmandatory approved these changes

@ValuedMammal ValuedMammal ValuedMammal approved these changes

Assignees

@luisschwab luisschwab

Labels
dependencies Pull requests that update a dependency file
Projects
BDK Wallet
Archived in project
Milestone
Wallet 2.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@luisschwab @coveralls @notmandatory @ValuedMammal