Skip to content

Conversation

@luisschwab
Copy link
Member

@luisschwab luisschwab commented May 16, 2025

Description

Closes #197.

Lists ValuedMammal as the owner of /wallet/.

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@coveralls

This comment was marked as off-topic.

@luisschwab
Copy link
Member Author

Rebased to trigger CI.

@ValuedMammal
Copy link
Collaborator

Sure I'll accept this change. I learned also there can be many code owners across the different modules and src files of a repo, which I also support.

Therefore, ACK.

@luisschwab
Copy link
Member Author

Yes it can be very fine grained. If you think someone else should be added let me know.

@notmandatory notmandatory added the chore Non-coding related work label May 28, 2025
@notmandatory notmandatory moved this to In Progress in BDK Wallet May 28, 2025
@notmandatory notmandatory added this to the Wallet 2.1.0 milestone May 28, 2025
Copy link
Collaborator

@ValuedMammal ValuedMammal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK f326113

@ValuedMammal ValuedMammal merged commit 4c2e000 into bitcoindevkit:master Jul 17, 2025
20 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in BDK Wallet Jul 17, 2025
@luisschwab luisschwab deleted the chore/codeowners branch September 22, 2025 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Non-coding related work

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Add CODEOWNERS flle

4 participants