Update README with new codecov badge #341
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #341 +/- ##
==========================================
+ Coverage 84.81% 84.99% +0.18%
==========================================
Files 23 23
Lines 8145 8237 +92
==========================================
+ Hits 6908 7001 +93
+ Misses 1237 1236 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| <a href="https://github.com/bitcoindevkit/bdk/blob/master/LICENSE"><img alt="MIT or Apache-2.0 Licensed" src="https://img.shields.io/badge/license-MIT%2FApache--2.0-blue.svg"/></a> | ||
| <a href="https://github.com/bitcoindevkit/bdk/actions?query=workflow%3ACI"><img alt="CI Status" src="https://github.com/bitcoindevkit/bdk/workflows/CI/badge.svg"></a> | ||
| <a href="https://coveralls.io/github/bitcoindevkit/bdk?branch=master"><img src="https://coveralls.io/repos/github/bitcoindevkit/bdk/badge.svg?branch=master"/></a> | ||
| <a href="https://codecov.io/github/bitcoindevkit/bdk_wallet" ><img src="https://codecov.io/github/bitcoindevkit/bdk_wallet/graph/badge.svg?token=UWNhCTN0pk"/></a> |
There was a problem hiding this comment.
What's the purpose of token query parameter? I removed it from the URL and the link still returned the same badge.
There was a problem hiding this comment.
Couldn't get much from https://docs.codecov.com/docs/status-badges, but they display the token on the pictures there, so this isn't an issue.
There was a problem hiding this comment.
Ah good question, it was the URL that the CodeCov admin page gave me so I think it's OK to use it as is. In other words I don't think the token is some extra tracking associated with advertising or something like that.
4 participants
Description
Now that #327 is merged and running we need to update the README badge.
Checklists
All Submissions:
just pbefore pushing