Minor fixes throughout codebase #2218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There has been a large increase in low effort PRs which simply fix a small typo (Or, often, suggest "fixes" which do not improve the relevant comment). These seem to be mostly bots likely looking for tokens awarded to ecosystem contributors so to avoid encouraging them, I've run though the suggested changes, added the ones which make sense to this PR and will close all of the bot PRs.
I've also added a line to the readme asking people to not submit PRs which simply fix a minor typo. This probably won't help with the bots but at least gives us something to point to.
Main Changes
Removing duplicated words.
Add license images to Readme. (Happy to get rid of these if we don't want them).
Fix spelling error: Reversable -> Reversible (This is technically an API breaking change but probably worth doing)
Add to readme about not accepting minor typo PR's. (Happy to get rid of this if we don't want them).