Dark mode for Registry Landing page #77
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@kouloumos @Emmanuel-Develops , do you think we should have all dark mode pages in one PR? |
0tuedon
force-pushed
the
landing-page-dark
branch
from
b13229b to
a0108c5
Compare
Emmanuel-Develops
force-pushed
the
staging
branch
from
f5e214e to
358e47a
Compare
|
Hello @0tuedon can you please rebase your branch to the latest on staging to resolve merge conflicts to enable me review this pull request |
0tuedon
force-pushed
the
landing-page-dark
branch
from
a0108c5 to
95e874f
Compare
0tuedon
force-pushed
the
landing-page-dark
branch
from
95e874f to
0d57b40
Compare
* feat: base search * feat: link pills, speakers and topic cards to search * feat: mobile responsiveness * fix: cleanups and loader * fix: sort fields and query * refactor: switch useSearch to context from hook * fix: prevent deopt to CSR with suspense * feat: clickable pills either as link or function * feat: loaders * fix: use tagsDetailed from rebase * fix: search behaviour logic and search results ui * refactor: break search box into mobile component, standalone mobile filter menu * fix(hydration-error): Pills as buttons on featured transcripts * fix(review-fixes): source naming, result card UI, pagination, readme, use summary * fix(review-fixes): searchbox clear on page navigation and get topic title for topics facet * feat(optimizations): too many unnecessary prefetch requests, remove bloated data from landing page * fix(search): prevent overflow on search results, add mapped topic name in applied filters * fix(mobile): quality of life improvements
Emmanuel-Develops
force-pushed
the
staging
branch
from
5fc22f8 to
1825a2c
Compare
* fix(nested-headings): nested headings for content grouping components * refactor(data-structure): changed complex data structure for contentGrouping and Transcript content page
0tuedon
force-pushed
the
landing-page-dark
branch
from
0d57b40 to
a255156
Compare
|
hi @IgboPharaoh @Emmanuel-Develops this PR has been updated |
Emmanuel-Develops
force-pushed
the
staging
branch
from
3b86286 to
9c2095d
Compare
kouloumos
reviewed
Mar 21, 2025
There was a problem hiding this comment.
Hey @0tuedon, I had a quick look at this, it looks good apart from two issues
- The explore pages (/categories, /topics) and the search page have a different dark color than the rest of the pages, which seems odd.
- The name of the speaker in the transcript's page is black, so it's not visible at all.
Also, this needs to be rebased.
There was a problem hiding this comment.
You'll need a new picture here, cause the those have since been changed on production
There was a problem hiding this comment.
You'll need a new picture here, cause the those have since been changed on production
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TO TEST:
Click on the toggle button on the header