Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new assertions #25

Merged
merged 3 commits into from
Jun 9, 2022
Merged

Add new assertions #25

merged 3 commits into from
Jun 9, 2022

Conversation

ammancilla
Copy link
Contributor

@ammancilla ammancilla commented May 5, 2022

Context: [internal link removed]

Add assert_changeset_valid/1 & refute_changeset_valid/1

@ammancilla ammancilla added the enhancement New feature or request label May 5, 2022
@ammancilla ammancilla self-assigned this May 5, 2022
@ammancilla ammancilla requested a review from maltoe May 5, 2022 11:33
Copy link
Contributor

@maltoe maltoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some documentation to the new functions

otherwise LGTM 💯

Copy link
Contributor

@maltoe maltoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ammancilla this somehow got lost a bit, sorry

👍 nice job

Co-authored-by: Malte Rohde <[email protected]>
@ammancilla ammancilla merged commit 2163bf4 into main Jun 9, 2022
@ammancilla ammancilla deleted the chore/add-new-assertions branch June 9, 2022 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants