-
Notifications
You must be signed in to change notification settings - Fork 9.5k
[bitnami/clickhouse] Stops unnecessary logging #32988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bitnami/clickhouse] Stops unnecessary logging #32988
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ilpianista
Thanks so much for the contribution! Given we're planning important changes at #32958, I'll block this PR until the mentioned changes are landed.
I see. But wouldn't it be better to release this change earlier so as not to force everyone to upgrade to the major version with ClickHouse Keeper? |
Hi @ilpianista
I don't think so given your changes don't require a new version since you're only modifying the default values that can be overriden while installing/upgrading the chart. |
fddc923
to
61218ca
Compare
@ilpianista we just merged the PR replacing ZooKeeper with ClickHouse Keeper bumping the chart major version. Please refer to the upgrading notes to learn more about these changes. Please note that now the default logging configuration is no longer in the values but in the ConfigMap below: As it's described in the README this logging configuration can be overriden by mounting a custom configuration file. For instance, using values like the ones below: configdFiles:
99-logger.xml: |
<yandex>
<logger>
<level>none</level>
</logger>
</yandex> |
80793c8
to
8030f75
Compare
Signed-off-by: Andrea Scarpino <[email protected]>
8030f75
to
227af1c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for rebasing from main
and adapting your changes! Please take a look to my suggestions when you have a chance.
Co-authored-by: Juan Ariza Toledano <[email protected]> Signed-off-by: Andrea Scarpino <[email protected]>
Co-authored-by: Juan Ariza Toledano <[email protected]> Signed-off-by: Andrea Scarpino <[email protected]>
Co-authored-by: Juan Ariza Toledano <[email protected]> Signed-off-by: Andrea Scarpino <[email protected]>
Signed-off-by: Bitnami Bot <[email protected]>
Signed-off-by: Bitnami Bot <[email protected]>
Signed-off-by: juan131 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description of the change
Disable Clickhouse logs which are used to analyze the details of query performance.
Benefits
Decrease clickhouse disk usage.
Possible drawbacks
Users should enable these logs when needed.
Applicable issues
Additional information
Checklist
Chart.yaml
according to semver. This is not necessary when the changes only affect README.md files.README.md
using readme-generator-for-helm