Add optional pre-upgrade hook delay #82434
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On clusters with slow network initialization the pre-upgrade hook may fail when etcdctl tries to contact etcd members before pod network is actually initialized. Optional customizable delay can be injected before running etcdctl to give kubelet enough time to initialize network. fixes bitnami#82322 Signed-off-by: Robert Moucha <[email protected]>
carrodher
added
verify
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Add optional delay before contacting etcd members in pre-upgrade helm hook checks.
Benefits
More reliable pre-upgrade hook, particularly on kubernetes clusters with slow network initialization.
I observed delays between "pod started" and "network ready" events about 600ms, so simply setting this
new variable to "1" should be enough in most cases.
Possible drawbacks
None, change is no-op if the variable is not set. If the variable is set, it slows down the helm hook run time by specified number of seconds.
Applicable issues