Skip to content

Conversation

@vvennela
Copy link

Changes proposed in this pull request:

  • Built the React Week 2 Curriculum
  • Goes over the JavaScript basics

@reviewer/Kevin

@lazyplatypus lazyplatypus requested a review from poroia February 19, 2020 02:47
Copy link
Contributor

@poroia poroia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome! One important thing I want to note is that we should put an emphasis on ES6 rather than it being a secondary thing. Like we introduce the topic with up-to-date ES6 syntax but also note older syntax. I noticed var is used throughout, change it to const and let because we'll be using that way more ---. an explanation as to how they work is in the 2nd checkbox.

Also, your images appear to be local, ask kevin how to put it on the web

there are a couple things I want to note:

  • we rarely ever write javascript directly in the <script> tag and it's really only for demos. we instead write code in a .js file and it's linked to the html through a src attribute like so:
    <script src="script.js"></script>
    you can indicate this in card 2 somewhere

  • so apart from card 2, I would recommend changing all code blocks to use the javascript format (it provides nice colors!) and remove the <script> tags.

  • for card 3, let and const keyword were introduced in ES6 and are different from var. let and var are kind of similar but differ in scope: var is function scoped, meaning that if you declare it in an if statement, it can be used outside the if . let is what you'd expect with a normal variable as in it's block scoped. const is a constant and cannot be changed and has the same scope as let.

  • for card 4, it's great! you might want to include ternary operators and say its an if statement but in a line (this is extremely useful in react)

  • side note: for an explanation above, you don't have to mention this now, maybe later when we get to react, but they're not only differentiated by its looks in terms of length. ternary operators are conditional expressions, while ifs are statements. in return statements, you can only use expressions but not statements:
    ie return x > 5 ? 'yes' : 'no'
    but you can't do: return if (x > 5) { yes }; else { no }

  • for card 6, you might want to mention map, filter , reduce which was introduced in ES5. it's another way of iteration and used a ton more in react

  • for card 8, separate selectors and events into different cards. selectors include getElementById(...), querySelector(...), getElementByClassName

  • for card 9, you might want to move arrow functions to card 7 and add it at the beginning (see msg at top)

other than that, it looks pretty awesome! I love the structure of the whole thing and the attention to detail for each card. keep up the awesome work!

@lazyplatypus
Copy link
Member

@vvennela Please make the changes Bryan mentioned and update this pull request 😄


Add this function to the <script> tag:

```javascript
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain what each function is suppose to do? Besides just say "insert this function". Rn all they are doing is just following instruction but remember the end goal is that the student learns

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This goes for this entire activity


![Screen Shot 2020-03-27 at 5.01.46 AM](/Users/vishnuv/Library/Application Support/typora-user-images/Screen Shot 2020-03-27 at 5.01.46 AM.png)

Choose the "Starter Clusters" Option and Create a cluster! A cluster is essentially a collection of various nodes, which each handle different parts of data. The main advantage that comes with using a cluster is that nodes are mainly independent of each other and can be examined seperately.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

explain what a node is? Explain collections. Explain what a NoSQL database and why it is important


![Screen Shot 2020-03-27 at 5.06.32 AM](/Users/vishnuv/Desktop/Screen Shot 2020-03-27 at 5.06.32 AM.png)

MongoDB uses collections in order to store data, which are basically like tables. No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explain how to filter through collections and data. Explain how to add data. There is much more to mongoDB atlas

@@ -0,0 +1,34 @@
# F1.2: Introduction to Stitch + Using Stitch

Another component of MongoDB is using Stich, which allows you to configure rules, authentication and other services for your services. To fully understand Stitch, let's build a blog which allows you to post and edit comments.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

explain rules, authentication and other services before diving into making a blog

Copy link
Contributor

@jeffchhen jeffchhen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all your cards. Please complete my edits by this weeks deadline (Sunday)

Thanks!


Another component of MongoDB is using Stich, which allows you to configure rules, authentication and other services for your services. To fully understand Stitch, let's build a blog which allows you to post and edit comments.

Make sure you've created your cluster and your account to access and finish this tutorial.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Show thme how to link the cluster to the stitch app


## Step 2: Authentication

On the starting page, scroll down and turn on "Anonymous Authentication." There are other ways to configure authentication, such as through Google or through username and password authentication.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is Authentication? What is the purpose of it? What difference does it make to do Anonymous vs Email/Pass


## Step 3: Setting Rules for the Application

1. On the Stich Homepage, click "Rules"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imagine yourself as someone new to MongoDB. Yes its easy to follow instructions but we want the person going through the content to learn what is going on. What is the purpose of a template? Why do we choose No Template? What if we wanted to use a template?

What is the difference between read and write columns?


![Screen Shot 2020-03-27 at 7.41.10 AM](/Users/vishnuv/Library/Application Support/typora-user-images/Screen Shot 2020-03-27 at 7.41.10 AM.png)

7. Finally, deploy your application. No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of deploying the application? What will this allow us to do?


Paste this below the SDK in the head tag:

Replace the "<your-app-id>" with your app id, which you can find on the clients page of the Stitch homepage
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

show them exactly where the app-id is


Add this function to the <script> tag:

```javascript
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This goes for this entire activity


![Screen Shot 2020-03-27 at 8.52.35 AM](/Users/vishnuv/Library/Application Support/typora-user-images/Screen Shot 2020-03-27 at 8.52.35 AM.png)

Accessing all this data means that you can take a closer look at the clusters formed. Try exploring the data to gain a greater understanding of how Compass functions and manipulates databases. No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explain to the user what each component of the GUI does

@@ -0,0 +1,37 @@
# F1.1 An Introduction to MongoDB and Atlas
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All your image tags are local. You need to upload them imgur or something and replace the links.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants