Skip to content

Conversation

@sarahg500
Copy link
Contributor

Issues Closed

Closes #780

Closes #972

...

Changes proposed in this pull request:

  • Adds 2 interview questions to queues activity, I created a new pull request since taimur's branch was a little confusing
  • I (Sarah) will update the READMe later

@reviewer/kavuong

@sarahg500 sarahg500 requested a review from mxthu313 April 2, 2020 22:08
@sarahg500 sarahg500 changed the base branch from master to Sarah-G April 2, 2020 22:08
@kavuong
Copy link
Contributor

kavuong commented Apr 3, 2020

@sarahg500 should #947 be closed?

@kavuong
Copy link
Contributor

kavuong commented Apr 3, 2020

never mind the pull request has very large edits which is most likely not the case

Copy link
Contributor

@mxthu313 mxthu313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@taimurkashif @tkashif <-- lol idk which one is really you

so you are supposed to walk through 1 leetcode activity. either one that you have written is fine (I really liked your explanation for the first one though). but you have to choose one, make 1 or 2 layers of complexity and walk the student through those until it gets to the original problem (we also wanna teach them how to "break down" a problem). Also mention the big O time and space analyses.

Generally speaking this is how leetcode breakdowns are supposed to be written:

  1. First card: Intro, setting up problems
  2. Second card: Lvl 1
  3. Third card: Lvl 2
  4. Fourth card: Lvl 3 (if applicable)
  5. Fifth card: Test Cases
  6. Sixth card: Time and Space Complexity

Working on modularizing and building up the problem statement
Continuing to modularize interview question. Have done up to the 4 directions being given in the problem statement
Have to add image in older Taimur branch
BFS maze picture for interview question added
Explained the importance of test cases
* Made part 4 and 5 of interview question
* Also updated credits in the answer.py file
@taimurkashif
Copy link
Contributor

@mxthu313
I think you get emailed about me pushing commits, but I just wanted to let you know I implemented your comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[D1.3] Queues: Leetcode Question [Activity 4.1.1] Queues: Context

5 participants