[NOJIRA] Validation metrics support + return issuer from validator #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #71 +/- ##
==========================================
- Coverage 70.64% 62.18% -8.47%
==========================================
Files 13 24 +11
Lines 293 595 +302
==========================================
+ Hits 207 370 +163
- Misses 68 192 +124
- Partials 18 33 +15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
metrics/datadog.go
Outdated
| return &DatadogMetrics{ | ||
| rawClient: c, | ||
| logger: logger, | ||
| }, func() { _ = c.Close() }, nil |
There was a problem hiding this comment.
I think, it would be better to update this class to implement the closer interface and call the c.Close() there instead of this second return value here.
| } | ||
|
|
||
| func (dm *DatadogMetrics) IncrRaw(name string, tags []string, rate float64) { | ||
| if err := dm.rawClient.Incr(name, tags, rate); err != nil { |
There was a problem hiding this comment.
Would you like to handle the case when the name is empty?
gaborpongracz
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.