fix(ci): scope Electron native rebuilds#1099
Merged
tomcasaburi merged 1 commit intomasterfrom Mar 17, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthroughThis PR restricts Electron native module rebuilds to only better-sqlite3 during packaging and adds CI timeout constraints. Changes modify the rebuild configuration in forge.config.js, update the rebuild script flag in package.json, and add timeouts to CI workflow steps. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related issues
Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope Electron native rebuilds to
better-sqlite3so the Windows package job stops rebuilding unrelated addons, and fail the standalone native-module step fast if it regresses.Closes #1098
Note
Medium Risk
Moderate risk because it changes Electron packaging/rebuild behavior and could cause missing native addons if other modules actually require rebuilds. Limited blast radius to CI/package pipeline, not runtime app logic.
Overview
Electron packaging CI now fails faster and rebuilds less. The
electron:prepare-packagestep in.github/workflows/ci.ymlhas a 10-minute timeout across Linux/macOS/Windows packaging jobs to avoid long hangs/regressions.Native rebuilds are scoped to
better-sqlite3.forge.config.jsrestricts Forge’srebuildConfigtoonlyModules: ['better-sqlite3'], andpackage.jsonupdateselectron:rebuild-nativeto useelectron-rebuild -o better-sqlite3so Windows packaging stops rebuilding unrelated optional addons.Written by Cursor Bugbot for commit 19da329. This will update automatically on new commits. Configure here.
Summary by CodeRabbit