Add static analysis (credo and dialyzer) and formatter #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanwinchester
force-pushed
the
feature/static-analysis-and-formatter
branch
3 times, most recently
from
c8292f4 to
9e8efbf
Compare
ryanwinchester
commented
Mar 4, 2022
| ' ', | ||
| Integer.to_charlist(y) | ||
| ] | ||
| |> :erlang.iolist_to_binary() |
There was a problem hiding this comment.
This is the only actual code change, since I think it's doing the same thing (but better?). Let me know if not.
- |> List.flatten |> List.to_string
+ |> :erlang.iolist_to_binary()
ryanwinchester
force-pushed
the
feature/static-analysis-and-formatter
branch
from
9e8efbf to
e055474
Compare
ryanwinchester
force-pushed
the
feature/static-analysis-and-formatter
branch
from
4decac4 to
fbd681a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure your opinion of some of these tools, let me know.
Action is running on fork: https://github.com/ryanwinchester/exirc/actions/workflows/tests.yaml