[PM-26772] Importing Archived Ciphers #6452
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6452 +/- ##
==========================================
+ Coverage 50.73% 54.81% +4.07%
==========================================
Files 1866 1866
Lines 82705 82707 +2
Branches 7310 7320 +10
==========================================
+ Hits 41961 45334 +3373
+ Misses 39143 35692 -3451
- Partials 1601 1681 +80 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Great job! No new security vulnerabilities introduced in this pull request |
|
|
||
| var ciphers = fixture.Build<CipherRequestModel>() | ||
| .With(_ => _.OrganizationId, orgId.ToString()) | ||
| .With(_ => _.FolderId, Guid.NewGuid().ToString()) |
There was a problem hiding this comment.
⛏️ Setting the folderId on orgItems isn't necessary.
| .With(c => c.OrganizationId, Guid.NewGuid().ToString()) | ||
| .With(c => c.FolderId, Guid.NewGuid().ToString()) |
There was a problem hiding this comment.
⛏️ The cipher when imported into an individual vault, won't have an orgId set and for the sake of the test a folderId is also not required.
There was a problem hiding this comment.
I was able to remove the organization Id. For the FolderId I had to set it to null otherwise the random guid that was generated would be parsed and result in an error being thrown. 27e396a
🎟️ Tracking
PM-26772
📔 Objective
When importing archived ciphers:
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes