Skip to content

Commit

Permalink
pytest-pep8 unmaintained, will need to find a replacement
Browse files Browse the repository at this point in the history
  • Loading branch information
@bjodah
bjodah committed Oct 30, 2020
1 parent c1dc81f commit 5b4bf0f
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions setup.cfg
View file
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
[tool:pytest]
norecursedirs = .* _* build dist conda-recipe scripts benchmarks doc deploy venv *cache*
pep8maxlinelength=119
pep8ignore =
doc/conf.py ALL # conf.py is a generated file
test_water_viscosity_korson_1969.py E222 # multiple spaces after operator
chempy/kinetics/tests/test_rates.py E221 E222 E226 E251
testpaths = chempy
# pep8maxlinelength=119
# pep8ignore =
# doc/conf.py ALL # conf.py is a generated file
# test_water_viscosity_korson_1969.py E222 # multiple spaces after operator
# chempy/kinetics/tests/test_rates.py E221 E222 E226 E251
flakes-ignore =
doc/conf.py ALL # conf.py is a generated file
__init__.py UnusedImport ImportStarUsed
Expand Down

2 comments on commit 5b4bf0f

@jeremyagray
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tried pytest-flake8 as a replacement. It required minimal changes to setup.cfg.

It works and appears to be maintained and generated plenty of violations.

If it is acceptable, I can PR the change and I'll start squashing the PEP8 violations.

@bjodah
Copy link
Owner Author

@bjodah bjodah commented on 5b4bf0f Oct 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I did try pytest-flake8 but couldn't get per file ignores to work. But if you can get it working, then that's great! A PR is most welcome.

Please sign in to comment.