Fix clippy warnings / Update lru and webpki-roots

Cargo.toml

@@ -20,7 +20,7 @@ futures-core = "0.3"
 futures-util = "0.3"
 futures-sink = "0.3"
 keyed_priority_queue = "0.4"
-lru = "0.14.0"
+lru = "0.16.0"
 mysql_common = { version = "0.35.4", default-features = false }
 pem = "3.0"
 percent-encoding = "2.1.0"
@@ -62,7 +62,7 @@ version = "2.1.0"
 optional = true
 
 [dependencies.webpki-roots]
-version = "0.26.1"
+version = "1.0.0"
 optional = true
 
 [dev-dependencies]

src/conn/routines/prepare.rs

@@ -38,7 +38,7 @@ impl Routine<Arc<StmtInner>> for PrepareRoutine {
             // The statement may contain sensitive data. Restrict to DEBUG.
             span.record(
                 "mysql_async.query.sql",
-                String::from_utf8_lossy(&*self.query).as_ref(),
+                String::from_utf8_lossy(&self.query).as_ref(),
             );
         }
 

src/error/mod.rs

@@ -315,14 +315,10 @@ impl From<PacketCodecError> for IoError {
     fn from(err: PacketCodecError) -> Self {
         match err {
             PacketCodecError::Io(err) => err.into(),
-            PacketCodecError::PacketTooLarge => {
-                io::Error::new(io::ErrorKind::Other, "packet too large").into()
-            }
-            PacketCodecError::PacketsOutOfSync => {
-                io::Error::new(io::ErrorKind::Other, "packet out of order").into()
-            }
+            PacketCodecError::PacketTooLarge => io::Error::other("packet too large").into(),
+            PacketCodecError::PacketsOutOfSync => io::Error::other("packet out of order").into(),
             PacketCodecError::BadCompressedPacketHeader => {
-                io::Error::new(io::ErrorKind::Other, "bad compressed packet header").into()
+                io::Error::other("bad compressed packet header").into()
             }
         }
     }

src/opts/mod.rs

@@ -149,7 +149,7 @@ pub enum PathOrBuf<'a> {
 
 impl<'a> PathOrBuf<'a> {
     /// Will either read data from disk or return the buffered data.
-    pub async fn read(&self) -> io::Result<Cow<[u8]>> {
+    pub async fn read(&self) -> io::Result<Cow<'_, [u8]>> {
         match self {
             PathOrBuf::Path(x) => tokio::fs::read(x.as_ref()).await.map(Cow::Owned),
             PathOrBuf::Buf(x) => Ok(Cow::Borrowed(x.as_ref())),

src/queryable/query_result/mod.rs

@@ -100,8 +100,8 @@ where
         self.conn
             .get_pending_result()
             .map(|pending_result| match pending_result {
-                Some(PendingResult::Pending(meta)) => meta.columns().len() > 0,
-                Some(PendingResult::Taken(meta)) => meta.columns().len() > 0,
+                Some(PendingResult::Pending(meta)) => !meta.columns().is_empty(),
+                Some(PendingResult::Taken(meta)) => !meta.columns().is_empty(),
                 None => false,
             })
             .unwrap_or(false)

src/queryable/transaction.rs

@@ -154,7 +154,7 @@ impl<'a> Transaction<'a> {
         }
 
         if let Some(isolation_level) = isolation_level {
-            let query = format!("SET TRANSACTION ISOLATION LEVEL {}", isolation_level);
+            let query = format!("SET TRANSACTION ISOLATION LEVEL {isolation_level}");
             conn.as_mut().query_drop(query).await?;
         }