Skip to content

Update/solid outline #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Update/solid outline #25

wants to merge 10 commits into from

Conversation

mirkokiefer
Copy link
Member

No description provided.

var shadowColor = NSColor.white
var shadowOffsetX = 1.5
var shadowOffsetY = 1.5
var shadowBlur = 2.0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ulian-onua I added this stub for a parameter struct that makes clear which options we have.
We should make it easy to wire this up with a settings interface and be able to serialize it.
The current way the parameters are passed in is a bit hard to understand - for example I didn't understand how the font color and separate color param is different.
If we can just use a simple struct like this and make it the public interface of the package that would make it easy to customize.

I'm thinking we should allow passing in an optional params struct like this which can also be used in the Annotations module to serialize to JSON. This way we can easily construct JSON-based examples for different scenarios in the Annotations module.
We might even decide to let Zappy users tweak these parameters in an advanced settings section later.

Let's add these params the public interface of this lib and then move the SwiftUI previews into the Annotations package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants