fix/refactor(CLL): Bump CLL version to 2.1.1 to exclude irrelevant directories when searching for locations (IDETECT-4810) #1572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shantyk
commented
Oct 9, 2025
| "If false, Detect will exclude the default directory names. See the detailed help for more information. Caution should be exercised when including this parameter on Windows, as the commmand length generated may exceed OS limitations.", | ||
| "If false, the following directories will be excluded by Detect when searching for detectors: __MACOX, bin, build, .git, .gradle, .yarn, node_modules, out, packages, target, .synopsys, .blackduck, and the following directories will be excluded from signature scan using the Scan CLI '--exclude' flag: .git, .gradle, gradle, node_modules, .synopsys, .blackduck." | ||
| "If false, Detect will exclude the default list of directory names when searching for applicable detectors (see property details for more information).", | ||
| "Directories excluded by default: __MACOX, bin, build, .git, .gradle, .yarn, node_modules, out, packages, target, .synopsys, .blackduck, and the following directories will be excluded from signature scan using the Scan CLI '--exclude' flag: .git, .gradle, gradle, node_modules, .synopsys, .blackduck." |
There was a problem hiding this comment.
Mainly wanted to remove the "Caution should be exercised when including this parameter on Windows, as the command length generated may exceed OS limitations" which doesn't apply to the property (its simply either TRUE or FALSE) but ended up rewording a little bit. cc: @cpottsbd
There was a problem hiding this comment.
I believe the command length concern refers to the command that gets issued by Detect when it tries to run the signature scanner.
See the change that introduced this message: https://github.com/blackducksoftware/detect/pull/896/files
There was a problem hiding this comment.
Thanks for tracking that down. I see the warning for the property "detect.excluded.directories" also, though for this one it makes sense
shantyk
changed the title
shantyk
changed the title
shantyk
requested review from
andrian-sevastyanov,
bd-samratmuk,
devmehtabd,
dterrybd and
zahidblackduck
andrian-sevastyanov
approved these changes
Oct 10, 2025
devmehtabd
approved these changes
Oct 13, 2025
cpottsbd
requested changes
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes IDETECT-4180
Please see related component locator library MRs under ticket.