Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comments to query language #2197

Merged
merged 1 commit into from
Dec 30, 2023
Merged

Conversation

TheMikeste1
Copy link
Contributor

This PR adds comments to DQL. Comments start with // and can be on their own line or after another statement.

Resolves #1624
[1] and [2] are implemented. [3] can be performed by creating multiple single-line comments.

Example:

// This is a comment at the beginning
TABLE (time-played + 100) as long, rating as rate, length
// This is a comment
// This is a second comment
FROM #games or #gaming  // This is an inline comment
// This is a third comment
WHERE long > 150 and rate - 10 < 40
// This is a fourth comment

   // This is a comment with whitespace prior
SORT length + 8 + 4 DESCENDING, long ASC
// This is a comment at the end

@blacksmithgu blacksmithgu merged commit 5fa107b into blacksmithgu:master Dec 30, 2023
3 checks passed
@Li-Mingshuang
Copy link

It hasn't been added to the released version?

@holroy
Copy link
Contributor

holroy commented Feb 16, 2024

It hasn't been added to the released version?

image

The 0.5.64 release was from Nov 2023, and this was added to the master branch in Dec 2023, so no it hasn't been released yet.

I'm playing with some other pull requests, so I'm hoping there'll be a release in a week or so (if someone capable of doing that approves of those PR's to come and those already accepted). One vital change though which needs to be done before a new release is released is this fix of the repetition of inline fields which was introduced around 0.5.59, see #2216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DQL Comments
4 participants