Skip to content

Quote executable name on Windows #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
salva wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Quote executable name on Windows #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions lib/Proc/Background/Win32.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,14 @@ sub _new {
# protected stay protected. Then convert unquoted "'s into \"'s.
# Finally, check for whitespace and protect it.
my @args;
my $exe;
if (@_ == 1) {
@args = split(' ', $_[0]);
$exe = $args[0];
} else {
@args = @_;
for (my $i=1; $i<@args; ++$i) {
$exe = $args[0];
for (my $i=0; $i<@args; ++$i) {
my $arg = $args[$i];
$arg =~ s#\\\\#\200#g;
$arg =~ s#\\"#\201#g;
Expand All @@ -64,8 +67,8 @@ sub _new {
# Win32::Process::Create cannot start a process when the full
# pathname has a space in it, convert the full pathname to the
# Windows short 8.3 format which contains no spaces.
$args[0] = Proc::Background::_resolve_path($args[0]) or return;
$args[0] = Win32::GetShortPathName($args[0]);
$exe = Proc::Background::_resolve_path($exe) or return;
$exe = Win32::GetShortPathName($exe);

my $self = bless {}, $class;

Expand All @@ -75,7 +78,7 @@ sub _new {

# Create the process.
if (Win32::Process::Create($os_obj,
$args[0],
$exe,
"@args",
0,
NORMAL_PRIORITY_CLASS,
Expand Down