Skip to content

added button (for exporting configs; do not merge)#1526

Draft
j-paterson wants to merge 90 commits intocanaryfrom
exportButton
Draft

added button (for exporting configs; do not merge)#1526
j-paterson wants to merge 90 commits intocanaryfrom
exportButton

Conversation

@j-paterson
Copy link
Collaborator

@j-paterson j-paterson commented Oct 30, 2025

Summary by CodeRabbit

  • New Features
    • Added an "Export Config" button to the Theme Settings Editor that appears when an export action is available. The full-width, centered button sits above the existing action area, includes a download icon and "Export Config" label, and invokes the provided export action when clicked.

willyogo and others added 30 commits October 17, 2025 18:20
- Add explicit display: flex to all div elements in channel OG image generation
- Resolves 500 error when generating OpenGraph images for channel pages
…data API

- Replace NextApiRequest/NextApiResponse with NextRequest for edge runtime
- Use robust URL parsing instead of fragile string splitting
- Add validation for required channelId parameter
- Return proper Response objects with HTTP status codes
- Addresses coderabbitai suggestions for type safety and runtime compatibility
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…#1494)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
willyogo and others added 24 commits November 6, 2025 14:44
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…251109.0 (#1547)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…emove legacy markdown Explore stuff (#1562)

Co-authored-by: Jesse Paterson <[email protected]>
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
src/common/lib/theme/ThemeSettingsEditor.tsx (1)

461-474: Minor styling cleanup available; duplication of export functionality is intentional.

The Export Config button is functional and the duplication with CodeTabContent is intentional—both components display export in different UI sections (ThemeSettingsEditor shows a simple button, CodeTabContent shows an elaborate section with description).

One minor improvement: the gap-2 class in the container is unnecessary since it contains only one button child. The width="auto" and className="w-full" pattern appears consistent elsewhere in the codebase and is likely intentional.

Apply this optional diff for minor cleanup:

-                {onExportConfig && (
-                  <div className="gap-2 pt-2 flex items-center justify-center">
+                {onExportConfig && (
+                  <div className="pt-2 flex items-center justify-center">
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 883aa74 and ed5da1c.

📒 Files selected for processing (1)
  • src/common/lib/theme/ThemeSettingsEditor.tsx (2 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-06-05T19:55:02.560Z
Learnt from: willyogo
Repo: Nounspace/nounspace.ts PR: 1118
File: src/common/fidgets/FidgetWrapper.tsx:160-175
Timestamp: 2025-06-05T19:55:02.560Z
Learning: In the Nounspace.ts codebase, fidget edit mode icons in FidgetWrapper.tsx require an extremely high z-index (999999) to prevent being covered by the tab bar. Lower z-index values like 1050 break this fix, indicating other UI elements use very high z-index values.

Applied to files:

  • src/common/lib/theme/ThemeSettingsEditor.tsx
🧬 Code graph analysis (1)
src/common/lib/theme/ThemeSettingsEditor.tsx (1)
src/common/components/atoms/button.tsx (1)
  • Button (81-81)
🔇 Additional comments (1)
src/common/lib/theme/ThemeSettingsEditor.tsx (1)

30-30: LGTM!

The FaDownload icon import is appropriate for the new Export Config button.

@willyogo willyogo marked this pull request as draft November 18, 2025 18:43
@willyogo willyogo changed the title added button added button (for exporting configs; do not merge) Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants