added button (for exporting configs; do not merge)#1526
added button (for exporting configs; do not merge)#1526j-paterson wants to merge 90 commits intocanaryfrom
Conversation
- Add explicit display: flex to all div elements in channel OG image generation - Resolves 500 error when generating OpenGraph images for channel pages
…data API - Replace NextApiRequest/NextApiResponse with NextRequest for edge runtime - Use robust URL parsing instead of fragile string splitting - Add validation for required channelId parameter - Return proper Response objects with HTTP status codes - Addresses coderabbitai suggestions for type safety and runtime compatibility
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…#1494) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…251109.0 (#1547) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jesse Paterson <[email protected]>
…e initial space configs (#1541)
Co-authored-by: xvlad <[email protected]>
Co-authored-by: sktbrd <[email protected]> Co-authored-by: xvlad <[email protected]>
Co-authored-by: Jesse Paterson <[email protected]>
Co-authored-by: Jesse Paterson <[email protected]>
…emove legacy markdown Explore stuff (#1562) Co-authored-by: Jesse Paterson <[email protected]>
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/common/lib/theme/ThemeSettingsEditor.tsx (1)
461-474: Minor styling cleanup available; duplication of export functionality is intentional.The Export Config button is functional and the duplication with
CodeTabContentis intentional—both components display export in different UI sections (ThemeSettingsEditor shows a simple button, CodeTabContent shows an elaborate section with description).One minor improvement: the
gap-2class in the container is unnecessary since it contains only one button child. Thewidth="auto"andclassName="w-full"pattern appears consistent elsewhere in the codebase and is likely intentional.Apply this optional diff for minor cleanup:
- {onExportConfig && ( - <div className="gap-2 pt-2 flex items-center justify-center"> + {onExportConfig && ( + <div className="pt-2 flex items-center justify-center">
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/common/lib/theme/ThemeSettingsEditor.tsx(2 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-06-05T19:55:02.560Z
Learnt from: willyogo
Repo: Nounspace/nounspace.ts PR: 1118
File: src/common/fidgets/FidgetWrapper.tsx:160-175
Timestamp: 2025-06-05T19:55:02.560Z
Learning: In the Nounspace.ts codebase, fidget edit mode icons in FidgetWrapper.tsx require an extremely high z-index (999999) to prevent being covered by the tab bar. Lower z-index values like 1050 break this fix, indicating other UI elements use very high z-index values.
Applied to files:
src/common/lib/theme/ThemeSettingsEditor.tsx
🧬 Code graph analysis (1)
src/common/lib/theme/ThemeSettingsEditor.tsx (1)
src/common/components/atoms/button.tsx (1)
Button(81-81)
🔇 Additional comments (1)
src/common/lib/theme/ThemeSettingsEditor.tsx (1)
30-30: LGTM!The
FaDownloadicon import is appropriate for the new Export Config button.
Summary by CodeRabbit