More feedback #49
Merged
More feedback #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markuspluna
reviewed
Mar 25, 2025
markuspluna
reviewed
Mar 25, 2025
markuspluna
reviewed
Mar 25, 2025
markuspluna
reviewed
Mar 25, 2025
Ryang-21
requested changes
Mar 25, 2025
…min and current admin cant sign the same tx
Ryang-21
approved these changes
Mar 26, 2025
markuspluna
reviewed
Mar 27, 2025
markuspluna
reviewed
Mar 27, 2025
|
|
||
| // spot price of backstop token in USDC, exlcuding slippage/fees | ||
| // LP token is 20% USDC, so 5x is the spot price without slippage/fees | ||
| let tkn_spot_price_sans_fee = usdc_per_tkn * 5; |
Contributor
There was a problem hiding this comment.
what's the point of this
markuspluna
requested changes
Mar 27, 2025
Contributor
markuspluna
left a comment
markuspluna
left a comment
There was a problem hiding this comment.
left a few comments worth addressing
Ryang-21
approved these changes
Mar 28, 2025
Ryang-21
approved these changes
Mar 31, 2025
markuspluna
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.