fix(sync-wallet): decouple batch broadcast from spend input matching#48
fix(sync-wallet): decouple batch broadcast from spend input matching#48
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts the wallet sync job so batch-broadcast ledger recording can occur even when spend-input accounting must be deferred (e.g., when bria’s UTXO table is missing some inputs), and adds an e2e regression test to validate the behavior.
Changes:
- Record batch-broadcast ledger markers independently from spend-input matching and spend accounting.
- Add explicit spend-input state handling and structured diagnostics for missing inputs.
- Add an e2e test covering a batch-linked spend with missing inputs, asserting broadcast marker presence plus diagnostics.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/job/sync_wallet.rs |
Refactors spend processing to separate batch-broadcast recording from spend-input matching and adds missing-input diagnostics. |
tests/e2e/bitcoind_sync.bats |
Adds an e2e regression ensuring batch broadcast markers are set even when spend inputs are missing. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
tests/e2e/bitcoind_sync.batscovering batch-linked spends with missing inputs and validating broadcast marker plus diagnostics behavior