-
Notifications
You must be signed in to change notification settings - Fork 13
fix: update node to 20.20.0-alpine #75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,4 +1,4 @@ | ||||||
| FROM node:20-alpine | ||||||
| FROM node:20.20.0-alpine | ||||||
|
||||||
| FROM node:20.20.0-alpine | |
| FROM node:20.20.0-alpine3.19 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| FROM node:20-alpine AS BUILD_IMAGE | ||
| FROM node:20.20.0-alpine AS BUILD_IMAGE | ||
|
||
|
|
||
| RUN apk update && apk add python3 make g++ | ||
|
|
||
|
|
@@ -13,7 +13,7 @@ RUN rm -rf /app/node_modules | |
| RUN rm -rf /app/realtime/node_modules | ||
| RUN yarn install --frozen-lockfile --production | ||
|
|
||
| FROM node:20-alpine | ||
| FROM node:20.20.0-alpine | ||
| COPY --from=BUILD_IMAGE /app/realtime/dist /app | ||
| COPY --from=BUILD_IMAGE /app/node_modules /app/node_modules | ||
| COPY --from=BUILD_IMAGE /app/realtime/node_modules /app/node_modules | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using a mutable tag (even with a pinned Node patch) can still lead to non-reproducible builds if the tag is rebuilt. For stronger supply-chain/reproducibility guarantees, consider pinning the base image by digest (node@sha256:...) and/or an explicit Alpine variant (e.g., -alpine3.xx) in both stages.