Skip to content

feat(telemetry): track successful voice starts - #210

Merged
johnmatthewtennant merged 2 commits into
mainfrom
jtennant/minimal-voice-telemetry
Aug 26, 2026
Merged

feat(telemetry): track successful voice starts#210
johnmatthewtennant merged 2 commits into
mainfrom
jtennant/minimal-voice-telemetry

Conversation

@johnmatthewtennant

@johnmatthewtennant johnmatthewtennant commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Summary

Berd cannot currently distinguish whether voice conversations are used. This adds the consent-gated berd_voice_conversation_started counter after native voice startup succeeds. The event has no attributes and collects no session, transcript, voice selection, or failure details.

Uploads opt into the strict berd-otlp-logs-v2 contract that accepts this counter.

Notes

berd-otlp-logs-v2 must be deployed in squareup/berd-monitoring before releasing this client version. End-to-end gateway verification requires that deployment.

@johnmatthewtennant
johnmatthewtennant marked this pull request as ready for review August 26, 2026 16:38
@johnmatthewtennant
johnmatthewtennant requested a review from a team August 26, 2026 16:38

@morgmart morgmart left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Automated code review

APPROVE. Fresh static review completed for the exact three-dot comparison d67756c...f43d7c2. The consent-gated voice-start counter is emitted only after native startup and microphone reconciliation succeed, carries no event attributes, and is covered for successful and failed startup. The schema-version update and exact wire/event literals are pinned by tests. Final self-check covered the changed voice-start and telemetry-upload flows; accessibility and localization (no changed UI or user-facing copy); navigation and consent guards; async failure, never-completes, lifecycle, and race behavior; test honesty; project/design-system rules; duplicate overlap; and severity evidence/user effect. No publishable findings survived. Supplied GitHub evidence was inspected: all nine check runs at the exact head SHA completed successfully, while the combined commit status is pending with no legacy statuses; required checks still govern merge readiness.

Deterministic publication result: 0 blocking and 0 non-blocking finding(s) publishable; 0 duplicate(s) suppressed.

Pending checks: 1 check(s) are not complete.

This approval reflects the completed code review only; merge readiness remains governed by the repository's required checks.

@johnmatthewtennant
johnmatthewtennant merged commit b340b9c into main Aug 26, 2026
9 checks passed
@johnmatthewtennant
johnmatthewtennant deleted the jtennant/minimal-voice-telemetry branch August 26, 2026 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants