Add sampled session feedback survey - #215
Open
comp615 wants to merge 4 commits into
Open
Conversation
Co-authored-by: Amp <amp@ampcode.com> Amp-Thread-ID: https://ampcode.com/threads/T-019fbabe-6c0e-70ab-8559-31ba601d4897
Amp-Thread-ID: https://ampcode.com/threads/T-019fbabe-6c0e-70ab-8559-31ba601d4897 Co-authored-by: Amp <amp@ampcode.com>
comp615
marked this pull request as ready for review
August 26, 2026 00:41
…ck-survey * ccroom/response-feedback-ui: Remove response feedback appearance events Amp-Thread-ID: https://ampcode.com/threads/T-019fbabe-6c0e-70ab-8559-31ba601d4897 Co-authored-by: Amp <amp@ampcode.com> # Conflicts: # src/features/chat/response-feedback/feedbackSurveySink.ts # src/features/chat/ui/MessageBubble.tsx
…ck-survey * ccroom/response-feedback-ui: Synchronize response feedback across renderers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR description was generated by AMP.
Summary
This builds the generic sampled session survey on top of the response-feedback seam. It is stacked on the response-feedback PR and should merge after it.
The prompt becomes eligible after five visible user turns and ten minutes, uses a distribution-owned basis-point sampling rate, and applies a persistent 27–29 hour device-wide cooldown. Dismiss is the default focus and Escape dismisses only while the visible survey owns focus. Stock Berd still sends nothing; distributions own transport and rollout values.
Virtualized transcripts include the survey in offscreen height measurements without letting the hidden measurement copy focus or emit feedback.
Related issue
N/A — no duplicate issue or PR found. Depends on response-feedback PR #214.
Testing
bin/just check bin/pnpm vitest run src/features/chat/response-feedback src/shared/runtime-config/schema.test.ts bin/just _tauri-cargo-unix test --lib feedback_survey bin/just tauri-checkAI tool validation prompt
Copy and paste into your AI tool: