Skip to content

chore: show Unity Catalog model names in the chat composer - #238

Merged
kalvinnchau merged 1 commit into
mainfrom
fix/databricks-unity-catalog-model-labels
Aug 27, 2026
Merged

chore: show Unity Catalog model names in the chat composer#238
kalvinnchau merged 1 commit into
mainfrom
fix/databricks-unity-catalog-model-labels

Conversation

@kalvinnchau

Copy link
Copy Markdown
Collaborator

Category: fix
User Impact: Databricks users can read the model name in the chat composer without catalog and schema prefixes obscuring it.

Problem: Unity Catalog models arrive as fully qualified $catalog.$schema.<model> identifiers, so the narrow composer picker truncates the most important final segment. Persisted selections and pre-discovery fallback labels could also continue showing the qualified identifier.

Solution: Keep the canonical identifier for selection and search while deriving composer-facing labels from the final model segment. Apply the same formatting to discovered options, direct ID fallbacks, and previously persisted qualified display names.

File changes

src/features/providers/lib/modelRecommendations.ts
Centralizes model-label derivation and strips the catalog/schema prefix from discovered Databricks Unity Catalog identifiers while preserving canonical IDs.

src/features/providers/lib/modelRecommendations.test.ts
Covers the discovered Unity Catalog option label and verifies the full ID remains intact.

src/features/chat/lib/modelDisplayLabel.ts
Uses model-only labels for composer fallbacks and repairs persisted qualified labels before inventory is available.

src/features/chat/lib/modelDisplayLabel.test.ts
Covers direct Unity Catalog selections, persisted labels, and non-Databricks behavior.

@kalvinnchau
kalvinnchau requested a review from a team August 27, 2026 00:45

@morgmart morgmart left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Automated code review

APPROVE. Fresh static review of the exact three-dot comparison c2fca34...3a78e36 found no publishable findings. The changed display-label derivation preserves canonical model IDs while consistently shortening Databricks Unity Catalog labels across discovered options, direct-ID fallback, and persisted qualified names; focused tests cover those paths and non-Databricks preservation. Final self-check covered every changed user flow; accessibility; i18n/localization completeness; navigation and consent guards; async, error, never-completes, lifecycle, and race behavior; test honesty; design-system/project rules; duplicate/overlapping findings; and concrete evidence plus user effect for blocking severity. No unsupported or overlapping findings survived. Supplied GitHub evidence was inspected: DCO and clean-room install passed, frontend and three Tauri checks were still in progress, and one close job was skipped; required checks still govern merge readiness.

Deterministic publication result: 0 blocking and 0 non-blocking finding(s) publishable; 0 duplicate(s) suppressed.

Pending checks: 5 check(s) are not complete.

This approval reflects the completed code review only; merge readiness remains governed by the repository's required checks.

@kalvinnchau kalvinnchau changed the title show Unity Catalog model names in the chat composer chore: show Unity Catalog model names in the chat composer Aug 27, 2026
@kalvinnchau
kalvinnchau enabled auto-merge (squash) August 27, 2026 00:53
@kalvinnchau
kalvinnchau merged commit 1f7adad into main Aug 27, 2026
9 checks passed
@kalvinnchau
kalvinnchau deleted the fix/databricks-unity-catalog-model-labels branch August 27, 2026 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants