feat: skip delete confirmation dialog when Option key is held - #598
Merged
Conversation
Thread altKey from the trash button's MouseEvent through TimelineRow → BranchTimeline → BranchCard so that Option+click deletes immediately without showing the confirmation dialog. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Remove unused altKey opts parameter from handleDeletePendingCommit since pending commits already delete immediately without confirmation. Make onDeleteClick opts parameter optional in TimelineRow to match caller signatures. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
altKeystate from the mouse event through the component hierarchy (TimelineRow→BranchTimeline→BranchCard)doDeleteclosure, used by both the instant-delete path and the confirmation dialog'sonConfirmcallbackTest plan
🤖 Generated with Claude Code