Skip to content

fix(staged): include isAuto in timeline reviews and filter consistently - #610

Merged
matt2e merged 2 commits into
mainfrom
repo-session-gets-queued
Apr 13, 2026
Merged

fix(staged): include isAuto in timeline reviews and filter consistently#610
matt2e merged 2 commits into
mainfrom
repo-session-gets-queued

Conversation

@matt2e

@matt2e matt2e commented Apr 13, 2026

Copy link
Copy Markdown
Contributor

Summary

Follow-up to #609 — the second commit didn't land before the merge.

  • Expose is_auto on ReviewTimelineItem from the backend instead of filtering auto-reviews out of the timeline entirely
  • Make isAuto a required field on the frontend ReviewTimelineItem type
  • Filter auto-reviews consistently across all frontend running-session checks and display logic (BranchCard, BranchCardSessionManager, DiffCommitSessionLauncher, BranchTimeline, liveSessionHints)

Without this, the frontend !isAuto guards from #609 were no-ops since auto-reviews were already stripped server-side.

Test plan

  • Trigger an auto-review and verify it doesn't block starting a new session
  • Verify auto-reviews don't appear in the branch timeline
  • Verify manual reviews still appear and function normally

🤖 Generated with Claude Code

matt2e and others added 2 commits April 13, 2026 11:10
Running auto-reviews were counted as active sessions in both the backend
(has_running_session_for_branch) and frontend (hasRunningSession), causing
user-initiated sessions to be queued until the background review finished.
Exclude is_auto reviews from the running session check.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The backend was filtering auto-reviews out of the timeline entirely,
so the frontend isAuto field was never populated. Instead, include
is_auto in ReviewTimelineItem from the backend and let the frontend
filter auto-reviews consistently across all running-session checks
and display logic.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@matt2e
matt2e requested review from baxen and wesbillman as code owners April 13, 2026 02:03
@matt2e
matt2e merged commit 993569b into main Apr 13, 2026
5 checks passed
@matt2e
matt2e deleted the repo-session-gets-queued branch April 13, 2026 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant