perf(diff-viewer): optimize buildFileEntries comment grouping - #619
Merged
Conversation
…o O(files*comments_per_basename) Pre-group comments by basename into a Map before iterating files, so each file only checks the small set of comment paths sharing its basename instead of scanning all comments. With 200 files and 50 comments this reduces pathsMatch calls from ~10,000 to a handful per update. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buildFileEntriesby pre-grouping comments into aMapkeyed by basename (filename)pathsMatchagainst the small set of comment paths sharing its basename, rather than scanning all commentspathsMatchcalls from ~10,000 to a handful per derived state updateDetails
The
buildFileEntriesfunction is called from a$derivedinDiffModal.svelte, so it re-runs on every state change (file review toggling, new comments, etc.). The previous implementation iterated all comments for every file. The new implementation:Map<basename, Map<commentPath, {count, types}>>in a single O(comments) passpathsMatchagainst that small grouppathsMatchsuffix-matching semantics exactlyTest plan
pathsMatchtests pass (10/10)svelte-checkpasses with 0 errors, 0 warnings🤖 Generated with Claude Code