fix(diff-viewer): cache flattened search results for O(1) lookups - #620
Merged
Conversation
…er cost getFlattenedResults() was being called 3 times per visible search result during rendering (once from isCurrentResult, twice from getGlobalIndex including a linear .find()), causing O(visible × total_matches) work per render. With 50 visible results and 500 total matches, this meant 75,000 iterations per render. Now caches the flattened array and a filePath→localIndex→globalIndex lookup Map, invalidated by identity checks on the inputs. getGlobalIndex is now O(1) via Map lookup instead of O(T) linear search. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getFlattenedResults()output using identity checks onfilesarray andfileResultsmap, avoiding O(total_matches) recomputation on every callMap<filePath, Map<localIndex, globalIndex>>lookup during flattening sogetGlobalIndex()is O(1) instead of O(total_matches) linear.find()Context
isCurrentResult()andgetGlobalIndex()are called once each per visible search result during rendering inFileSearchResults.svelte. Both calledgetFlattenedResults()which rebuilds the entire flattened array every time, andgetGlobalIndexadditionally did a.find()linear scan. With 50 visible results and 500 total matches this caused ~75,000 iterations per render.Test plan
🤖 Generated with Claude Code