fix(desktop): simplify Databricks model labels - #3586
Conversation
Signed-off-by: kenny lopez <klopez4212@gmail.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ed6043f26c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: kenny lopez <klopez4212@gmail.com>
Chessing234
left a comment
There was a problem hiding this comment.
Clean display-only cleanup for Databricks gateway IDs — keeping the raw endpoint ID for selection while showing a human model name is the right split. Tests around agentCardModelLabel / formatAgentModelLabel pin it. LGTM.
Chessing234
left a comment
There was a problem hiding this comment.
Approving the Databricks model label display cleanup.
I found several presentation gaps that should be addressed before merge:
Please route the missed surfaces through the formatter, derive the stable selected label from the matching formatted option, fix the two real-ID cases, and add regression coverage. I verified that selection and persistence still use raw model IDs; this finding is presentation-only, but presentation consistency is the purpose of this PR. |
Summary
Testing
pnpm checkpnpm testpnpm exec tsc --noEmit