fix(acp): fence terminal message publication - #3589
Open
youlikemodernart wants to merge 3 commits into
Open
Conversation
Signed-off-by: youlikemodernart <youlikemodernart@users.noreply.github.com>
Signed-off-by: youlikemodernart <youlikemodernart@users.noreply.github.com>
youlikemodernart
force-pushed
the
prep/terminal-publication-upstream
branch
from
July 30, 2026 20:10
dedc423 to
509b387
Compare
Signed-off-by: youlikemodernart <youlikemodernart@users.noreply.github.com>
youlikemodernart
force-pushed
the
prep/terminal-publication-upstream
branch
from
July 30, 2026 20:11
509b387 to
ce23496
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Managed ACP turns can finish or be cancelled while a descendant
buzzcommand is still preparing a channel reply. Stopping the model turn alone does not prevent that descendant from submitting a late message.This change adds a cross-process publication fence around managed ACP turns:
messages sendandmessages send-diff;buzzCLI capability in managed ACP and Sprig packages;!cancel @Agent Name, while retaining exact owner, event-kind, and target-agent tag checks.Unix teardown uses the ACP process group. Windows uses safe
taskkill /T /F /PID; a failed tree kill cannot report successful settlement while a descendant still holds the publication lease.Related issue
Fixes #3587
Testing
No UI changed, so screenshots are not applicable.
Passed locally on macOS:
cargo fmt --all -- --check;buzz-acpandbuzz-cli, all targets, with warnings denied;buzz-acpunit tests;buzz-clitests;buzz-publication-fencetests;messages send-diffrejection regression;git diff --check.Manual product validation also passed:
Full
just ciremains blocked by one deterministic current-main mobile widget failure:ChannelDetailPage keeps follow mode off while a tall newest message stays visibleThe exact focused mobile test fails repeatedly, and this PR has no
mobile/diff. The unrelated test was not skipped or weakened.Native Windows execution was not available locally. The Windows process-tree path is compile-gated and should run in CI.