fix(acp): handle missing custom harness binaries - #3598
Open
svndco wants to merge 1 commit into
Open
Conversation
Deserialize Desktop's missing_binary setup requirement, render external PATH/install guidance, and avoid routing external-only cards to Edit Agent. Co-authored-by: Jeremy Allen <jeremy@svnd.co> Signed-off-by: Jeremy Allen <jeremy@svnd.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
missing_binarysetup requirement inbuzz-acpmissing_binarypayloads with Rust and Desktop regression testsRoot cause
Buzz Desktop serializes
Requirement::MissingBinaryintoBUZZ_ACP_SETUP_PAYLOAD, butbuzz-acpdid not define the matchingRequirementPayloadvariant. The setup listener exited on the unknownmissing_binarysurface. Desktop also treated the resulting external-only card as clickable and routed it to Edit Agent, which cannot repair PATH or install the command.Verification
env -u BUZZ_ACP_LAZY_POOL just ciOriginating Buzz channel:
7e0c8692-da17-4ab3-817b-1a03b8f9d771