fix(desktop): confirm before re-adding mentioned non-member agents - #3599
Open
Chessing234 wants to merge 1 commit into
Open
fix(desktop): confirm before re-adding mentioned non-member agents#3599Chessing234 wants to merge 1 commit into
Chessing234 wants to merge 1 commit into
Conversation
Mentioning a removed managed agent no longer silently re-attaches them. Non-member agent mentions go through the invite dialog; ensure-ready only starts agents that are already channel members. Signed-off-by: Taksh <takshkothari09@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
|
@tlongwell-block @wesbillman @wpfleger96 mind taking a look when you get a chance? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@mentionedensureManagedAgentMentionsReadyonly starts agents already in the channelWhy
After Remove from channel, typing
@Agentwas undoing the removal and immediately prompting the agent (#3577). The channel owner’s only lever to keep an agent out was being silently overridden.Test plan
@mentionthem — invite dialog appears; choosing Do nothing does not re-addFixes #3577
Made with Cursor