Skip to content

fix(desktop): make harness errors runtime-neutral - #3781

Draft
tbedor-square2 wants to merge 1 commit into
block:mainfrom
tbedor-square2:tbedor/harness-neutral-errors
Draft

fix(desktop): make harness errors runtime-neutral#3781
tbedor-square2 wants to merge 1 commit into
block:mainfrom
tbedor-square2:tbedor/harness-neutral-errors

Conversation

@tbedor-square2

Copy link
Copy Markdown

Why

A bare ACP -32603 Internal error does not identify the failing harness, but Buzz always showed Codex-specific troubleshooting. That sent users of Amp and other ACP runtimes toward unrelated configuration.

What

  • Replace the Codex-specific fallback with harness-neutral runtime-log guidance
  • Preserve adapter-provided details and add a regression that generic errors never mention Codex

Risk Assessment

Low — this only changes desktop copy for bare ACP internal errors; structured and detailed error handling is unchanged.

References

  • Complements fix(acp): preserve JSON-RPC error data #2436, which preserves JSON-RPC error data when adapters provide it
  • Validation: desktop checks; full desktop test suite (3,819/3,819); focused friendlyAgentLastError tests (32/32); desktop typecheck
  • Repository-wide just ci reaches an unrelated existing macOS clippy failure for Linux-only helpers in desktop/src-tauri/src/linux_media.rs

Generated with Codex

Signed-off-by: Tom Bedor <tbedor@squareup.com>
@Chessing234

Copy link
Copy Markdown
Contributor

thanks. please call out any migration/restart step in the pr body so operators dont miss it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants