feat(desktop): authorize existing external agents - #3807
Draft
michegz wants to merge 1 commit into
Draft
Conversation
Co-authored-by: michegz <michelle@homeguardprogroup.com> Signed-off-by: michegz <michelle@homeguardprogroup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Originating Buzz channel:
1685d446-b7a8-4e2e-b602-c6c6f9eab06aWhy
External agents can be added to a channel as bots, but closed Buzz relays also
require a valid owner-signed NIP-OA authorization. Before this change, Desktop
had no owner-reviewed way to mint that credential for an existing external bot.
Security boundaries
botchannel roleflow and copied to the clipboard for installation in the external agent
Verification
just desktop-checkjust desktop-testjust desktop-buildjust desktop-tauri-checkjust desktop-tauri-test— 1,923 passed, 0 failed, 14 ignoredpnpm build:e2e && pnpm exec playwright test --only-changed=origin/main— 74 passed
just cireaches an existing macOS clippy failure indesktop/src-tauri/src/linux_media.rs: three Linux-only helpers are consideredunused under
-D warnings. This branch does not change that file; thefeature-specific Rust, TypeScript, build, and changed-spec E2E checks above pass.