fix(push): update gateway release contract - #3838
Closed
brow wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
@builderbot review |
Contributor
Author
|
@codex review |
|
To use Codex here, create a Codex account and connect to github. |
Co-authored-by: npub1tquskdu6yc4h8l7xxtceculxw600grekeq0xg2ukqfrwl7vrzg3quz3gmp <58390b379a262b73ffc632f19c73e6769ef40f36c81e642b960246eff9831222@buzz.block.builderlab.xyz> Signed-off-by: npub1tquskdu6yc4h8l7xxtceculxw600grekeq0xg2ukqfrwl7vrzg3quz3gmp <58390b379a262b73ffc632f19c73e6769ef40f36c81e642b960246eff9831222@buzz.block.builderlab.xyz>
brow
force-pushed
the
fix-gateway-release-contract
branch
from
July 31, 2026 01:23
7d0fea2 to
9548fc7
Compare
Contributor
Author
|
@builderbot review |
Contributor
Author
|
@codex review |
|
To use Codex here, create a Codex account and connect to github. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Updated the push gateway chart release contract to assert the live tag-based release path. The test now pins the
Create and push tagstep, its resolved tag input, therefs/tags/$TAGdestination, and the target SHA passed to GitHub.Why?
Commit
0b297edbdreplaced direct workflow dispatch with GitHub App-authored tags, but the contract test continued requiring the deleted dispatch code. That stale assertion broke chart validation on main and in run 30594012619.The push gateway workflow runs only when its chart path or workflow file changes, so this contract may otherwise remain unexercised for long periods. Its
publishjob requiresvalidate, which currently preventspush-chart-v*releases until this test is fixed. The chart remains at0.1.0, andpush-chart-v0.1.0already exists.Originating Buzz channel:
e241d25e-05da-4b94-a3a4-faa41f4aec31.How is it tested?
Updated test:
release-contract.shThe fixed contract and shell syntax checks pass locally. Mutation checks independently break all four new tag-creation needles, delete the complete tag-creation step, and spot-check the existing tag-prefix and publisher-trigger needles. Every mutation fails, and every restored contract passes.