fix(sdk): allow CJK-adjacent @mentions without breaking emails (#3904) - #3917
Open
Chessing234 wants to merge 5 commits into
Open
fix(sdk): allow CJK-adjacent @mentions without breaking emails (#3904)#3917Chessing234 wants to merge 5 commits into
Chessing234 wants to merge 5 commits into
Conversation
Contributor
Author
|
Friendly review ping for @block/buzz-oss-team — CI/DCO are green on the latest push and this is ready for a maintainer pass when you have bandwidth. Happy to rebase or split if that helps review. |
CJK and other scripts often omit spaces around agent names. Treat any non-alphanumeric ASCII predecessor as a mention boundary while still rejecting email-like `user@host` (block#3904). Signed-off-by: Taksh <takshkothari09@gmail.com> Signed-off-by: Taksh <takshkothari09@gmail.com>
Give operators and agent authors a short table for block#3904 without reading the Rust module docs. Signed-off-by: Taksh <takshkothari09@gmail.com> Signed-off-by: Taksh <takshkothari09@gmail.com>
Point agent authors at the boundary rule so handoffs without spaces still wake harnesses (block#3904). Signed-off-by: Taksh <takshkothari09@gmail.com> Signed-off-by: Taksh <takshkothari09@gmail.com>
Keep the CJK vs email rule discoverable from the contributor guide (block#3904). Signed-off-by: Taksh <takshkothari09@gmail.com> Signed-off-by: Taksh <takshkothari09@gmail.com>
Demonstrate that messages send emits p-tags for spaced-less handoffs. Signed-off-by: Taksh <takshkothari09@gmail.com> Signed-off-by: Taksh <takshkothari09@gmail.com>
Chessing234
force-pushed
the
fix/cjk-mention-boundary-3904
branch
from
August 2, 2026 03:58
2edbe97 to
86a52d0
Compare
Contributor
Author
|
Rebased onto latest |
Contributor
Author
|
@tlongwell-block @wesbillman @wpfleger96 mind taking a look when you get a chance? |
Chessing234
force-pushed
the
fix/cjk-mention-boundary-3904
branch
from
August 5, 2026 10:34
86a52d0 to
3344196
Compare
Contributor
Author
|
@wesbillman sdk @mention fix for cjk-adjacent tokens without breaking emails. tip is rebased + dco. review/merge when you can? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@mentionextraction when@is preceded by anything other than an ASCII letter/digit — so交给@Scout处理emits aptag whileuser@example.comstays inert (Proposal: define CLI/SDK @mention behavior next to CJK text #3904).extract_at_mentions_with_knownwith the same char-aware boundary (it previously inspected a single UTF-8 byte) and treat trailing CJK as a word boundary.docs/mention-boundaries.md, AGENTS gotchas, CONTRIBUTING, and the CLI README.Test plan
cargo test -p buzz-sdk extract_at_namescargo test -p buzz-sdk extract_at_mentions_with_known_allows_cjk_adjacentcargo test -p buzz-sdk email_address_not_matchedbuzz messages send --content "交给@Scout处理"against a channel where Scout is a member → Scout receives a mention / agent wakesCloses #3904
Made with Cursor