Skip to content

test(relay): serialize flaky trace_context_lookup callsite test under ENV_LOCK (#3929) #4059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
iroiro147 wants to merge 1 commit into from
+10 −0
Closed

test(relay): serialize flaky trace_context_lookup callsite test under ENV_LOCK (#3929) #4059

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions crates/buzz-relay/src/telemetry.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,6 +473,16 @@ mod tests {

#[test]
fn trace_context_lookup_does_not_enable_callsites() {
// #3929: this test intermittently failed under the parallel suite
// because `tracing`'s callsite *interest* cache is global per
// callsite, not per-subscriber. A neighbor test that registers a
// global default dispatcher can poison this callsite's cached
// interest before our thread-local `with_default` runs, so the probe
// consults a stale entry. Serialize against the other global-state
// tests via the shared ENV_LOCK (the same mutex they already take),
// so no global-dispatcher registration can overlap this test.
let _guard = ENV_LOCK.lock().unwrap();

let context_lookup = TraceContextLookup::default();
let subscriber = tracing_subscriber::registry().with(
context_lookup
Expand Down