feat(acp): explain rejected inbound messages - #4064
Draft
brow wants to merge 5 commits into
Draft
Conversation
Co-authored-by: Tom Brow <tomb@block.xyz> Signed-off-by: Tom Brow <tomb@block.xyz>
Co-authored-by: Tom Brow <tomb@block.xyz> Signed-off-by: Tom Brow <tomb@block.xyz>
Co-authored-by: Tom Brow <tomb@block.xyz> Signed-off-by: Tom Brow <tomb@block.xyz>
Co-authored-by: Tom Brow <tomb@block.xyz> Signed-off-by: Tom Brow <tomb@block.xyz>
Co-authored-by: Tom Brow <tomb@block.xyz> Signed-off-by: Tom Brow <tomb@block.xyz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When someone without access messages a managed agent, the inbound author gate silently drops the event. The sender cannot tell whether the agent is ignoring them, unavailable, or restricted to its owner.
This complements #4053, which provides the internal-build owner-only enforcement.
Changes
crates/buzz-acp/src/inbound_denial.rsrespond-to=nobody.crates/buzz-acp/src/lib.rsTests
Added coverage:
allowed_input_proceeds_when_every_denial_condition_is_truementioned_input_suppresses_denial_when_falsecooled_down_input_suppresses_denial_when_falsekind_input_suppresses_denial_when_falsechannel_capacity_never_repeals_an_existing_channel_capfull_author_map_fails_closed_without_erasing_existing_cooldownsnobody_mode_suppresses_denial_for_an_otherwise_qualifying_messageQuality gates at tip
33c6e04e134c1b0d25a4d05da325d7118145b18dOriginated from Buzz channel buzz-agent-control.