security(cli): prefer file/stdin/env over --private-key argv (#4032) - #4096
Open
Chessing234 wants to merge 6 commits into
Open
security(cli): prefer file/stdin/env over --private-key argv (#4032)#4096Chessing234 wants to merge 6 commits into
Chessing234 wants to merge 6 commits into
Conversation
Chessing234
force-pushed
the
security/private-key-file-deprecation
branch
from
August 1, 2026 11:52
5a71669 to
62b1396
Compare
Contributor
Author
|
Rebased with |
Contributor
Author
|
Friendly review ping for @block/buzz-oss-team — CI/DCO are green on the latest push and this is ready for a maintainer pass when you have bandwidth. Happy to rebase or split if that helps review. |
Implements preference order and argv detection so --private-key can be deprecated without dropping BUZZ_PRIVATE_KEY support (block#4032). Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: Taksh <takshkothari09@gmail.com>
Wires the new flags through clap and run(), warning when the secret is passed on argv into shell history / process listings. Signed-off-by: Taksh <takshkothari09@gmail.com>
Documents the safer identity sources and links block#4032 for the argv leak. Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: Taksh <takshkothari09@gmail.com>
Cross-links block#4032 next to the existing BUZZ_PRIVATE_KEY keyring guidance. Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: Taksh <takshkothari09@gmail.com>
Keeps the manual test script aligned with the safer auth sources. Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: Taksh <takshkothari09@gmail.com>
Keeps agent docs aligned with the block#4032 argv deprecation. Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: Taksh <takshkothari09@gmail.com>
Chessing234
force-pushed
the
security/private-key-file-deprecation
branch
from
August 2, 2026 03:58
62b1396 to
e9ee13a
Compare
Contributor
Author
|
Rebased onto latest |
Contributor
Author
|
@tlongwell-block @wesbillman @wpfleger96 mind taking a look when you get a chance? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--private-key-fileand--private-key-stdin; keepsBUZZ_PRIVATE_KEY.--private-keyappears on argv (shell history /ps).Fixes #4032
Test plan
cargo test -p buzz-cli private_keycargo test -p buzz-cli cli_definition_is_validbuzz --private-key-file /tmp/nsec channels list(with valid key)printf '%s' "$NSEC" | buzz --private-key-stdin channels listbuzz --private-key nsec1… …prints deprecation warningMade with Cursor